Fix registration error caused by a non-existing role name. #143
Conversation
UserManager->createUserRole uses the role key instead of the role name to create a new user, because the role name should be only a human readable value and not a key
| { | ||
| /** @var RoleInterface $role */ | ||
| $role = $this->roleRepository->findOneBy(['name' => $roleName]); | ||
| $role = $this->roleRepository->findOneBy(['key' => $roleName]); |
There was a problem hiding this comment.
Thank you for the pull request! It looks like this is a bug and was forgotten to be changed in #130.
Unfortunately, the new implementation might break things for users that use an older Sulu version. Therefore we need to fallback to the old behaviour like in the InitCommand:
SuluCommunityBundle/Command/InitCommand.php
Lines 146 to 153 in 9a5da07
Also, i think it would be nice to update the code and use roleKey instead of roleName as variable name in the InitCommand, UserManager and UserManagerInterface 🙂
|
@alexander-schranz Any chance to get this merged? When using the CommunityBundle its not possible to use the "name" field of the user roles as it will break the registration. |
3 participants
UserManager->createUserRole uses the role key instead of the role name to create a new user, because the role name should be only a human readable value and not a key
What's in this PR?
the commit-msg describes itself
Why?